media/base/android/media_source_player.cc - Issue 171233007: Don't process pending prefetch events if we fail to create video decoder job

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_source_player.cc

Issue 171233007: Don't process pending prefetch events if we fail to create video decoder job (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: modify the test to have a pending prefetch request after setting an empty surface Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/android/media_source_player.cc

diff --git a/media/base/android/media_source_player.cc b/media/base/android/media_source_player.cc

index 598ff6b036ad4124daa3f0e7f7b7bce51f5deb80..61fc9fbd54f0eb9241a684ccfb1851de2df60f1f 100644

--- a/media/base/android/media_source_player.cc

+++ b/media/base/android/media_source_player.cc

@@ -525,9 +525,8 @@ void MediaSourcePlayer::ProcessPendingEvents() {

ConfigureVideoDecoderJob();

// Return early if we can't successfully configure a new video decoder job

- // yet, except continue processing other pending events if |surface_| is

- // empty.

- if (HasVideo() && !video_decoder_job_ && !surface_.IsEmpty())

+ // yet.

+ if (HasVideo() && !video_decoder_job_)

return;

}

« no previous file with comments | « no previous file | media/base/android/media_source_player_unittest.cc » ('j') | media/base/android/media_source_player_unittest.cc » ('J')