Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1712313002: Get LibraryElement(s) and CompilationUnitElement(s) from summary. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get LibraryElement(s) and CompilationUnitElement(s) from summary. With this change we fail just 2 shared tests when use SDK summary. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bfd8e7ba0953e57d1b36b00ee598ea7449004c6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -19 lines) Patch
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +49 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-19 19:25:31 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-19 19:27:44 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-19 19:42:59 UTC) #3
scheglov
4 years, 10 months ago (2016-02-19 21:10:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bfd8e7ba0953e57d1b36b00ee598ea7449004c6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698