Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712233002: 9/ Thin out dependencies (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@8name
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Thin out dependencies BUG= Committed: https://crrev.com/1120bd329976ebed47873e9f3b9206d204800eca Cr-Commit-Position: refs/heads/master@{#376660}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -37 lines) Patch
M mojo/shell/BUILD.gn View 1 2 chunks +4 lines, -12 lines 0 comments Download
M mojo/shell/background/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download
M mojo/shell/runner/child/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/shell/runner/host/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/shell/standalone/BUILD.gn View 1 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-19 21:39:19 UTC) #3
sky
LGTM
4 years, 10 months ago (2016-02-19 22:38:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712233002/40001
4 years, 10 months ago (2016-02-20 23:48:08 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-21 00:25:32 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-21 00:26:22 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1120bd329976ebed47873e9f3b9206d204800eca
Cr-Commit-Position: refs/heads/master@{#376660}

Powered by Google App Engine
This is Rietveld 408576698