Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1712203002: Revert of Non-pattern rewriting revisited (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Non-pattern rewriting revisited (patchset #3 id:40001 of https://codereview.chromium.org/1702063002/ ) Reason for revert: [Sheriff] This makes jsfunfuzz unhappy: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/7681 Original issue's description: > This patch implements an alternative approach to the rewriting > of non-pattern expressions, according to the (internally circulated) > design document. Details to be provided here. > > 1. RewritableAssignmentExpression has been renamed to RewritableExpression. > It is a wrapper for AST nodes that wait for some potential rewriting > (that may or may not happen). Also, Is... and As... macros now see > through RewritableExpressions. > > 2. The function state keeps a list of rewritable expressions that must be > rewritten only if they are used as non-pattern expressions. > > 3. Expression classifiers are now templates, parameterized by parser > traits. They keep some additional state: a pointer to the list of > non-pattern rewritable expressions. It is important that expression > classifiers be used strictly in a stack fashion, from now on. > > 4. The RewriteNonPattern function has been simplified. > > BUG=chromium:579913 > LOG=N > > Committed: https://crrev.com/7f5c864a6faf2b957b7273891e143b9bde35487c > Cr-Commit-Position: refs/heads/master@{#34154} TBR=rossberg@chromium.org,bmeurer@chromium.org,titzer@chromium.org,nikolaos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:579913 Committed: https://crrev.com/5bb6b47bd565ee9b5ceec052c4dd8378f4c59a1a Cr-Commit-Position: refs/heads/master@{#34158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -370 lines) Patch
M src/ast/ast.h View 6 chunks +22 lines, -71 lines 0 comments Download
M src/ast/ast-expression-rewriter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ast/ast-expression-visitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/ast-literal-reindexer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ast/prettyprinter.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/typing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/parsing/expression-classifier.h View 6 chunks +23 lines, -52 lines 0 comments Download
M src/parsing/parser.h View 7 chunks +14 lines, -16 lines 0 comments Download
M src/parsing/parser.cc View 21 chunks +71 lines, -68 lines 0 comments Download
M src/parsing/parser-base.h View 46 chunks +77 lines, -94 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/parsing/preparser.h View 6 chunks +20 lines, -20 lines 0 comments Download
M src/parsing/preparser.cc View 12 chunks +18 lines, -16 lines 0 comments Download
M src/typing-asm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/asm-wasm-builder.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Non-pattern rewriting revisited
4 years, 10 months ago (2016-02-19 15:05:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712203002/1
4 years, 10 months ago (2016-02-19 15:06:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 15:06:22 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:06:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bb6b47bd565ee9b5ceec052c4dd8378f4c59a1a
Cr-Commit-Position: refs/heads/master@{#34158}

Powered by Google App Engine
This is Rietveld 408576698