content/browser/renderer_host/media/web_contents_audio_input_stream.h - Issue 17122006: Rejigger audio capture pipeline to work with separate main+worker threads (Mac).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/web_contents_audio_input_stream.h

Issue 17122006: Rejigger audio capture pipeline to work with separate main+worker threads (Mac). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace use of scoped_refptr<Worker> with simple DeleteSoon() scheme. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_input_renderer_host.cc ('k') | content/browser/renderer_host/media/web_contents_audio_input_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/web_contents_audio_input_stream.h

diff --git a/content/browser/renderer_host/media/web_contents_audio_input_stream.h b/content/browser/renderer_host/media/web_contents_audio_input_stream.h

index b424801bfbb53de17adac61a32e0489725f78bb5..139882bfcb17ed2b81781a27dd14058797343a33 100644

--- a/content/browser/renderer_host/media/web_contents_audio_input_stream.h

+++ b/content/browser/renderer_host/media/web_contents_audio_input_stream.h

@@ -55,10 +55,13 @@ class CONTENT_EXPORT WebContentsAudioInputStream

// WebContentsCaptureUtil::ExtractTabCaptureTarget(). The caller must

// guarantee Close() is called on the returned object so that it may

// self-destruct.

+ // |worker_loop| is the loop on which AudioInputCallback methods are called

+ // and may or may not be the single thread that invokes the AudioInputStream

+ // methods.

static WebContentsAudioInputStream* Create(

const std::string& device_id,

const media::AudioParameters& params,

- const scoped_refptr<base::MessageLoopProxy>& message_loop);

+ const scoped_refptr<base::MessageLoopProxy>& worker_loop);

private:

friend class WebContentsAudioInputStreamTest;

@@ -72,7 +75,6 @@ class CONTENT_EXPORT WebContentsAudioInputStream

WebContentsAudioInputStream(

int render_process_id, int render_view_id,

- const scoped_refptr<base::MessageLoopProxy>& message_loop,

AudioMirroringManager* mirroring_manager,

const scoped_refptr<WebContentsTracker>& tracker,

media::VirtualAudioInputStream* mixer_stream);