Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1712063002: [fusl] Consistently name asm files .s, not .S (Closed)

Created:
4 years, 10 months ago by kulakowski
Modified:
4 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[fusl] Consistently name asm files .s, not .S "A foolish consistency is the hobgoblin of little minds, adored by little statesmen and philosophers and divines." -- Ralph Waldo Emerson R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d1cff7ff763278bab3e6dcf59e50aee6fe73ff8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-5 lines, -597 lines) Patch
D fusl/src/fenv/arm/fenv-hf.S View 1 chunk +0 lines, -69 lines 0 comments Download
A + fusl/src/fenv/arm/fenv-hf.s View 0 chunks +-1 lines, --1 lines 0 comments Download
D fusl/src/fenv/mips/fenv.S View 1 chunk +0 lines, -71 lines 0 comments Download
A + fusl/src/fenv/mips/fenv.s View 0 chunks +-1 lines, --1 lines 0 comments Download
D fusl/src/setjmp/mips/longjmp.S View 1 chunk +0 lines, -40 lines 0 comments Download
A + fusl/src/setjmp/mips/longjmp.s View 0 chunks +-1 lines, --1 lines 0 comments Download
D fusl/src/setjmp/mips/setjmp.S View 1 chunk +0 lines, -39 lines 0 comments Download
A + fusl/src/setjmp/mips/setjmp.s View 0 chunks +-1 lines, --1 lines 0 comments Download
D fusl/src/string/arm/memcpy_le.S View 1 chunk +0 lines, -383 lines 0 comments Download
A + fusl/src/string/arm/memcpy_le.s View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kulakowski
4 years, 10 months ago (2016-02-19 00:27:53 UTC) #1
viettrungluu
lgtm
4 years, 10 months ago (2016-02-19 17:22:47 UTC) #2
kulakowski
4 years, 10 months ago (2016-02-19 17:31:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1cff7ff763278bab3e6dcf59e50aee6fe73ff8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698