Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1712023002: Generate useful toString() methods for summary classes. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate useful toString() methods for summary classes. This should make debugging easier. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4cd82a693ef5ac903f00a29e74255160a24fea25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+483 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/base.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 41 chunks +426 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 4 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-18 23:19:49 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-19 00:38:46 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-19 16:33:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4cd82a693ef5ac903f00a29e74255160a24fea25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698