Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1711983002: Fix generate_emma_html.py failing due to 0-length .em files (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, Menglin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix generate_emma_html.py failing due to 0-length .em files This also makes it return non-zero when the .html is not actually created. BUG=587983 Committed: https://crrev.com/ae67350c3a10889adb6bf3f47002227546245737 Cr-Commit-Position: refs/heads/master@{#376348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/android/generate_emma_html.py View 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
agrieve
On 2016/02/18 21:42:15, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org > - mailto:mlliu@chromium.org ...
4 years, 10 months ago (2016-02-18 21:42:33 UTC) #4
jbudorick
lgtm
4 years, 10 months ago (2016-02-18 21:45:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711983002/1
4 years, 10 months ago (2016-02-19 01:05:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 02:20:38 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 02:21:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae67350c3a10889adb6bf3f47002227546245737
Cr-Commit-Position: refs/heads/master@{#376348}

Powered by Google App Engine
This is Rietveld 408576698