Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1711923002: Revert of Add additive animation support for CSS property background-position (Closed)

Created:
4 years, 10 months ago by Fady Samuel
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, Eric Willigers, Mikhail, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add additive animation support for CSS property background-position (patchset #7 id:120001 of https://codereview.chromium.org/1680803003/ ) Reason for revert: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=animations%2Fbackground-shorthand-crash.html&testType=layout-tests failing. This sounds related. Reverting. Original issue's description: > Add additive animation support for CSS property background-position > > This patch adds support for composite modes on background-position > CSS animations via element.animate(). > > BUG=437696 > > Committed: https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7 > Cr-Commit-Position: refs/heads/master@{#376155} TBR=dstockwell@chromium.org,ericwilligers@chromium.org,haraken@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -502 lines) Patch
D third_party/WebKit/LayoutTests/animations/composition/background-position-composition.html View 1 chunk +0 lines, -89 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/background-position-origin-interpolation.html View 5 chunks +20 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/background-position-origin-interpolation-expected.txt View 3 chunks +60 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/responsive/background-position-responsive.html View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 4 chunks +26 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.h View 1 chunk +27 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 1 chunk +0 lines, -139 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/RefVector.h View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Fady Samuel
Created Revert of Add additive animation support for CSS property background-position
4 years, 10 months ago (2016-02-18 19:25:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711923002/1
4 years, 10 months ago (2016-02-18 19:27:03 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:30:42 UTC) #4
Failed to apply patch for third_party/WebKit/Source/core/style/ComputedStyle.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/style/ComputedStyle.h:140
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: third_party/WebKit/Source/core/style/ComputedStyle.h: patch does not
apply

Patch:       third_party/WebKit/Source/core/style/ComputedStyle.h
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h
b/third_party/WebKit/Source/core/style/ComputedStyle.h
index
a500b10215d338bf13665344e012a6f07d7e5dc1..01814ea8ba804c99f9bff1aed255aac9d4d52a23
100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -140,7 +140,6 @@
     friend class CachedUAStyle; // Saves Border/Background information for
later comparison.
     friend class ColorPropertyFunctions; // Reads initial style values and
accesses visited and unvisited colors.
     friend class LengthPropertyFunctions; // Reads initial style values.
-    friend class LengthListPropertyFunctions; // Reads initial style values.
     friend class NumberPropertyFunctions; // Reads initial style values.
     friend class PaintPropertyFunctions; // Reads initial style values.

Powered by Google App Engine
This is Rietveld 408576698