Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1711883003: [turbofan] Relax restrictions on JSCreate inlining. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@FastNewObjectStub
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Relax restrictions on JSCreate inlining. No need to limit JSCreate inlining to JS_OBJECT_TYPE, since we can handle everything that the FastNewObjectStub can deal with. Also we don't need to restrict the number of inobject properties, as that is already taken care of by the runtime anyways (limited by the initial slack for the constructor). And last but not least, we can of course inline allocations for subclasses as long as the new.target is a JSFunction and it's initial map's constructor points back to the target (same condition as for the FastNewObjectStub fast case). R=jarin@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/24c8f0b056ad306951759c33cefb5224c17e8b05 Cr-Commit-Position: refs/heads/master@{#34138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M src/compiler/js-create-lowering.cc View 2 chunks +24 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-19 06:26:14 UTC) #1
Jarin
lgtm
4 years, 10 months ago (2016-02-19 07:39:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711883003/1
4 years, 10 months ago (2016-02-19 07:39:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 07:41:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 07:41:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24c8f0b056ad306951759c33cefb5224c17e8b05
Cr-Commit-Position: refs/heads/master@{#34138}

Powered by Google App Engine
This is Rietveld 408576698