Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1711873002: Fix for summarizing typedef typed parameters. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -33 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 5 chunks +33 lines, -31 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-18 17:43:06 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-18 17:57:12 UTC) #2
scheglov
4 years, 10 months ago (2016-02-18 17:59:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
712c8d750ca58c1eef431a9d22a8d9cd74636fd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698