Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: pkg/dart_messages/lib/shared_messages.dart

Issue 1711863005: Split the JSON output into multiple lines. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dart_messages/lib/generated/shared_messages.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart_messages/lib/shared_messages.dart
diff --git a/pkg/dart_messages/lib/shared_messages.dart b/pkg/dart_messages/lib/shared_messages.dart
index ff9329629aa74e3f9e042d9857ca8113ad415b94..a58cbbfa024e7c5afc7afac36a0ff98b381caf9e 100644
--- a/pkg/dart_messages/lib/shared_messages.dart
+++ b/pkg/dart_messages/lib/shared_messages.dart
@@ -138,9 +138,9 @@ class Message {
}
String get messagesAsJson {
- var jsonified = {};
+ var jsonifiedEntries = [];
MESSAGES.forEach((String name, Message message) {
- jsonified[name] = {
+ jsonifiedEntries.add("'$name': " + JSON.encode({
Siggi Cherem (dart-lang) 2016/02/18 20:55:02 or use `const JsonEncoder.withIndent(' ').encode(
floitsch 2016/02/18 21:00:48 Even better. Dart really has great libraries ;)
'id': message.id,
'subId': message.subId,
'category': message.category.name,
@@ -150,9 +150,12 @@ String get messagesAsJson {
'options': message.options,
'usedBy': message.usedBy.map((platform) => platform.toString()).toList(),
'examples': message.examples,
- };
+ }));
});
- return JSON.encode(jsonified);
+ return """
+ {
+ ${jsonifiedEntries.join(",\n")}
+ }""";
}
final Map<String, Message> MESSAGES = {
« no previous file with comments | « pkg/dart_messages/lib/generated/shared_messages.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698