Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1711863005: Split the JSON output into multiple lines. (Closed)

Created:
4 years, 10 months ago by floitsch
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split the JSON output into multiple lines. Otherwise a git grep will produce a huge output when finding the entry in the json db. R=brianwilkerson@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7a7ecf299ba684f81931a8c5ed2cf42eca4f573d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ues JsonEncoder.withIndent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -21 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/generated/shared_messages.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 4 chunks +2 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dart_messages/lib/generated/shared_messages.json View 1 1 chunk +315 lines, -1 line 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 1 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
floitsch
4 years, 10 months ago (2016-02-18 20:51:32 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1711863005/diff/1/pkg/dart_messages/lib/shared_messages.dart File pkg/dart_messages/lib/shared_messages.dart (right): https://codereview.chromium.org/1711863005/diff/1/pkg/dart_messages/lib/shared_messages.dart#newcode143 pkg/dart_messages/lib/shared_messages.dart:143: jsonifiedEntries.add("'$name': " + JSON.encode({ or use `const JsonEncoder.withIndent(' ...
4 years, 10 months ago (2016-02-18 20:55:02 UTC) #3
floitsch
https://codereview.chromium.org/1711863005/diff/1/pkg/dart_messages/lib/shared_messages.dart File pkg/dart_messages/lib/shared_messages.dart (right): https://codereview.chromium.org/1711863005/diff/1/pkg/dart_messages/lib/shared_messages.dart#newcode143 pkg/dart_messages/lib/shared_messages.dart:143: jsonifiedEntries.add("'$name': " + JSON.encode({ On 2016/02/18 20:55:02, Siggi Cherem ...
4 years, 10 months ago (2016-02-18 21:00:48 UTC) #4
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-18 21:04:13 UTC) #5
floitsch
4 years, 10 months ago (2016-02-18 21:15:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7a7ecf299ba684f81931a8c5ed2cf42eca4f573d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698