Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711833002: Mark old SetAccessCheckCallback as deprecated (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark old SetAccessCheckCallback as deprecated R=verwaest@chromium.org LOG=y BUG=none Committed: https://crrev.com/78f3b2faf50f7e4f103348f4bc45571d10bfc0e7 Cr-Commit-Position: refs/heads/master@{#34142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-18 16:51:46 UTC) #1
Toon Verwaest
lgtm
4 years, 10 months ago (2016-02-19 08:08:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711833002/1
4 years, 10 months ago (2016-02-19 08:14:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 08:37:31 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 08:37:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/78f3b2faf50f7e4f103348f4bc45571d10bfc0e7
Cr-Commit-Position: refs/heads/master@{#34142}

Powered by Google App Engine
This is Rietveld 408576698