Chromium Code Reviews| Index: media/audio/pulse/pulse_util.h |
| diff --git a/media/audio/pulse/pulse_util.h b/media/audio/pulse/pulse_util.h |
| index b8e5cdcda4c606eaef98770e1507bbff99522855..c9a9209f57c91cf16f1d802cbfac15e8feddf310 100644 |
| --- a/media/audio/pulse/pulse_util.h |
| +++ b/media/audio/pulse/pulse_util.h |
| @@ -48,11 +48,12 @@ void WaitForOperationCompletion(pa_threaded_mainloop* mainloop, |
| int GetHardwareLatencyInBytes(pa_stream* stream, |
| int sample_rate, |
| int bytes_per_frame); |
| - |
| // Create a recording stream for the threaded mainloop, return true if success, |
| // otherwise false. |mainloop| and |context| have to be from a valid Pulse |
| // threaded mainloop and the handle of the created stream will be returned by |
| // |stream|. |
| +// TODO: Move this function to PulseAudioInputStream class since it's only |
|
Henrik Grunell
2016/03/09 00:49:17
"TODO:" -> "TODO(grunell):". Ditto below.
rchtara
2016/03/09 16:16:10
Done.
|
| +// used there. |
| bool CreateInputStream(pa_threaded_mainloop* mainloop, |
| pa_context* context, |
| pa_stream** stream, |
| @@ -65,8 +66,10 @@ bool CreateInputStream(pa_threaded_mainloop* mainloop, |
| // otherwise false. This function will create a new Pulse threaded mainloop, |
| // and the handles of the mainloop, context and stream will be returned by |
| // |mainloop|, |context| and |stream|. |
| -bool CreateOutputStream(pa_threaded_mainloop** mainloop, |
| - pa_context** context, |
| +// TODO: Move this function to PulseAudioOutputStream class since it's only |
| +// used there. |
| +bool CreateOutputStream(pa_threaded_mainloop* mainloop, |
| + pa_context* context, |
| pa_stream** stream, |
| const AudioParameters& params, |
| const std::string& device_id, |