Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711813003: [classes] Support AccessorInfo-style data properties in super property stores. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[classes] Support AccessorInfo-style data properties in super property stores. BUG= Committed: https://crrev.com/77e30f013a221527bb4ab955188aec44f10fee7f Cr-Commit-Position: refs/heads/master@{#34163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M src/objects.cc View 1 chunk +9 lines, -1 line 0 comments Download
A + test/mjsunit/es6/classes-super.js View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-19 15:08:28 UTC) #2
rossberg
lgtm
4 years, 10 months ago (2016-02-19 15:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711813003/1
4 years, 10 months ago (2016-02-19 15:30:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 16:03:57 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 16:04:50 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/77e30f013a221527bb4ab955188aec44f10fee7f
Cr-Commit-Position: refs/heads/master@{#34163}

Powered by Google App Engine
This is Rietveld 408576698