Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711813002: check for zero conic weights in interp (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

check for zero conic weights in interp this will fix the current (and uncover the next) ASAN failure TBR=tomhudson@google.com BUG=skia:4549 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711813002 Committed: https://skia.googlesource.com/skia/+/dcd1fcc6e9891e1427c8ce4500edac45a8687fbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/core/SkPath.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711813002/1
4 years, 10 months ago (2016-02-18 16:29:52 UTC) #3
caryclark
4 years, 10 months ago (2016-02-18 16:29:56 UTC) #4
tomhudson
So if there are no weights, it *is* interpolable?
4 years, 10 months ago (2016-02-18 16:34:25 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 17:00:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dcd1fcc6e9891e1427c8ce4500edac45a8687fbd

Powered by Google App Engine
This is Rietveld 408576698