Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711793002: Sort headers in non-xfa directories. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sort headers in non-xfa directories. This CL runs the chromium sort-headers.py script over the non-xfa code. XFA will be done after the includes have been updated to full paths. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/61046b948a7a15a605147635d317ff3bb27fb452

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -44 lines) Patch
M core/include/fxcrt/fx_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_system.h View 1 chunk +2 lines, -2 lines 2 comments Download
M core/src/fpdfapi/fpdf_basic_module.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_gcc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_util.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 1 chunk +1 line, -0 lines 2 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/public_methods_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/fx_string_testhelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/test_support.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL. https://codereview.chromium.org/1711793002/diff/1/core/include/fxcrt/fx_system.h File core/include/fxcrt/fx_system.h (right): https://codereview.chromium.org/1711793002/diff/1/core/include/fxcrt/fx_system.h#newcode58 core/include/fxcrt/fx_system.h:58: #include <windows.h> I don't know why the script ...
4 years, 10 months ago (2016-02-18 16:22:58 UTC) #2
Tom Sepez
LGTM based on spot inspection. Let's hope it builds. https://codereview.chromium.org/1711793002/diff/1/core/include/fxcrt/fx_system.h File core/include/fxcrt/fx_system.h (right): https://codereview.chromium.org/1711793002/diff/1/core/include/fxcrt/fx_system.h#newcode58 core/include/fxcrt/fx_system.h:58: ...
4 years, 10 months ago (2016-02-18 19:39:57 UTC) #3
dsinclair
4 years, 10 months ago (2016-02-18 19:48:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
61046b948a7a15a605147635d317ff3bb27fb452 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698