Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711783003: Remove support for TreatReturnedNullStringAs=Null|Undefined (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for TreatReturnedNullStringAs=Null|Undefined document.defaultCharset was the last user and is now removed: https://codereview.chromium.org/1707473002 BUG=497982 Committed: https://crrev.com/5d556a9f35a850563e9be6805273c35b492df837 Cr-Commit-Position: refs/heads/master@{#376419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -391 lines) Patch
M third_party/WebKit/LayoutTests/fast/js/webidl-type-mapping.html View 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/webidl-type-mapping-expected.txt View 4 chunks +0 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 3 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +0 lines, -291 lines 0 comments Download
M third_party/WebKit/Source/core/testing/TypeConversions.idl View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711783003/1
4 years, 10 months ago (2016-02-19 02:52:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 04:56:21 UTC) #4
philipj_slow
PTAL. I was meaning to ask bashi@, but he's apparently OOO.
4 years, 10 months ago (2016-02-19 05:40:32 UTC) #6
haraken
LGTM! Thanks for the nice cleaup!
4 years, 10 months ago (2016-02-19 07:32:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711783003/1
4 years, 10 months ago (2016-02-19 08:25:55 UTC) #9
philipj_slow
On 2016/02/19 07:32:21, haraken wrote: > LGTM! Thanks for the nice cleaup! Thanks! I've also ...
4 years, 10 months ago (2016-02-19 08:26:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 08:35:48 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 08:37:04 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5d556a9f35a850563e9be6805273c35b492df837
Cr-Commit-Position: refs/heads/master@{#376419}

Powered by Google App Engine
This is Rietveld 408576698