Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1711763005: Don't measure CPU time in timing out GPU watchdog. (Closed)

Created:
4 years, 10 months ago by jbauman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't measure CPU time in timing out GPU watchdog. It's possible for the main thread to hang on a GPU event or waiting for the OS, so if CPU usage is required for timing out the watchdog then it's possible it'll never time out. Just remove the code that checks for CPU time. Time lost due to suspend/resume events should be handled by the PowerMonitor, and this code seems to work on other platforms without issues. BUG=588342 Committed: https://crrev.com/ae57b78041762268e1898c165e33b904477433bb Cr-Commit-Position: refs/heads/master@{#376867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -83 lines) Patch
M content/gpu/gpu_watchdog_thread.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 6 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbauman
4 years, 10 months ago (2016-02-22 21:24:20 UTC) #2
Ken Russell (switch to Gerrit)
LGTM if this has been tested, in particular on a laptop with multiple suspend/resume cycles.
4 years, 10 months ago (2016-02-22 22:09:39 UTC) #3
jbauman
On 2016/02/22 22:09:39, Ken Russell wrote: > LGTM if this has been tested, in particular ...
4 years, 10 months ago (2016-02-22 22:51:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711763005/1
4 years, 10 months ago (2016-02-22 22:53:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 00:28:34 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae57b78041762268e1898c165e33b904477433bb Cr-Commit-Position: refs/heads/master@{#376867}
4 years, 10 months ago (2016-02-23 00:29:45 UTC) #9
jbauman
4 years, 10 months ago (2016-02-23 20:30:08 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1725983002/ by jbauman@chromium.org.

The reason for reverting is: Too many hangs are caused by slow startup: 
BUG=589175.

Powered by Google App Engine
This is Rietveld 408576698