third_party/WebKit/LayoutTests/fast/css/window-internals-isCSSPropertyUseCounted.html - Issue 1711703002: Add internals.isCSSPropertyUseCounted functionality

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/window-internals-isCSSPropertyUseCounted.html

Issue 1711703002: Add internals.isCSSPropertyUseCounted functionality (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4

	5 <style>

	6 div {

	7 padding-left: 100px;

	8 padding-bottom: 100px;

	9 color:green;

	10 background-color: blue;

	11 opacity: 100px;
	alancutter (OOO until 2018) 2016/02/24 02:45:52 We should make invalid values obvious e.g. "opacit We should make invalid values obvious e.g. "opacity: invalid value;". nainar 2016/02/24 03:34:25 Done. Done.
	12 border: black solid 5px;

	13 }

	14 </style>

	15

	16 <div id="target"></div>

	17

	18 <script>

	19 test(function() {

	20 assert_true(window.internals.isCSSPropertyUseCounted(document, "color")) ;
	alancutter (OOO until 2018) 2016/02/24 02:45:52 No need for "window.". No need for "window.". nainar 2016/02/24 03:34:25 Done. Done.
	21 assert_true(window.internals.isCSSPropertyUseCounted(document, "backgrou nd-color"));

	22 assert_true(window.internals.isCSSPropertyUseCounted(document, "padding- bottom"));

	23 assert_true(window.internals.isCSSPropertyUseCounted(document, "padding- left"));

	24 }, "Test setting and reading css properties");

	25

	26 test(function() {

	27 assert_true(window.internals.isCSSPropertyUseCounted(document, "border") )

	28 assert_false(window.internals.isCSSPropertyUseCounted(document, "border- color"));

	29 assert_false(window.internals.isCSSPropertyUseCounted(document, "border- style"));

	30 assert_false(window.internals.isCSSPropertyUseCounted(document, "border- width"));

	31 }, "Test setting a shorthand and reading longhand");

	32

	33 test(function() {

	34 assert_false(window.internals.isCSSPropertyUseCounted(document, "opacity "));

	35 }, "Test windows.internal.isCSSPropertyUseCounted functionality - a property not set in author stylesheet should be false");
	alancutter (OOO until 2018) 2016/02/24 02:45:52 This description is a bit weird, it's actually tes This description is a bit weird, it's actually testing a property with an invalid value. Can we have both? You should add a test for properties set only in the user agent stylesheet. nainar 2016/02/24 03:34:25 Done. Done.
	36

	37 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('J')