Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 1711673003: Synthetic constructors resulting from mixins should never be const (issue 25738) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: cleanup Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/compile_time_error_code_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 44c7137bc2049fbf7ec19f586c81b3df4aa12d77..dbd5f23ca78e440ec0bd1619a025d5d98e69940a 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -705,7 +705,6 @@ class ClassElementImpl extends ElementImpl implements ClassElement {
new ConstructorElementImpl(superclassConstructor.name, -1);
implicitConstructor.synthetic = true;
implicitConstructor.redirectedConstructor = superclassConstructor;
- implicitConstructor.const2 = superclassConstructor.isConst;
implicitConstructor.returnType = type;
List<ParameterElement> superParameters = superclassConstructor.parameters;
int count = superParameters.length;
@@ -4547,6 +4546,11 @@ class TypeParameterElementImpl extends ElementImpl
TypeParameterElementImpl(String name, int offset) : super(name, offset);
/**
+ * Initialize a newly created type parameter element to have the given [name].
+ */
+ TypeParameterElementImpl.forNode(Identifier name) : super.forNode(name);
+
+ /**
* Initialize a newly created synthetic type parameter element to have the
* given [name], and with [synthetic] set to true.
*/
@@ -4554,11 +4558,6 @@ class TypeParameterElementImpl extends ElementImpl
synthetic = true;
}
- /**
- * Initialize a newly created type parameter element to have the given [name].
- */
- TypeParameterElementImpl.forNode(Identifier name) : super.forNode(name);
-
@override
ElementKind get kind => ElementKind.TYPE_PARAMETER;
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/compile_time_error_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698