Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1711673003: Synthetic constructors resulting from mixins should never be const (issue 25738) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Synthetic constructors resulting from mixins should never be const (issue 25738) R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/554a5e7f064d889e5986c132b08782d26484b1b1

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -24 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 3 chunks +35 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-18 19:05:59 UTC) #2
Paul Berry
lgtm
4 years, 10 months ago (2016-02-18 19:37:31 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-18 19:42:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
554a5e7f064d889e5986c132b08782d26484b1b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698