Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 171163003: Add version info resource to the it2me and me2me native messaging hosts. (Closed)

Created:
6 years, 10 months ago by weitao
Modified:
6 years, 10 months ago
Reviewers:
Sergey Ulanov, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add version info resource to the it2me and me2me native messaging hosts. BUG=338952, 325567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251921

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M remoting/host/win/version.rc.jinja2 View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting_host.gypi View 3 chunks +26 lines, -0 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
weitao
https://codereview.chromium.org/171163003/diff/1/remoting/remoting_host.gypi File remoting/remoting_host.gypi (right): https://codereview.chromium.org/171163003/diff/1/remoting/remoting_host.gypi#newcode592 remoting/remoting_host.gypi:592: 'SubSystem': '1', # /SUBSYSTEM:CONSOLE The default value is '1'. ...
6 years, 10 months ago (2014-02-18 20:11:24 UTC) #1
Sergey Ulanov
lgtm https://codereview.chromium.org/171163003/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/171163003/diff/1/remoting/resources/remoting_strings.grd#newcode684 remoting/resources/remoting_strings.grd:684: Native messaging host process On 2014/02/18 20:11:24, weitaosu ...
6 years, 10 months ago (2014-02-18 22:27:27 UTC) #2
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 10 months ago (2014-02-18 22:40:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/171163003/70001
6 years, 10 months ago (2014-02-18 22:42:48 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 02:06:13 UTC) #5
Message was sent while issue was closed.
Change committed as 251921

Powered by Google App Engine
This is Rietveld 408576698