Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl

Issue 1711543002: Add enums to KeyframeEffectOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl
diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl b/third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl
index 95859482b40d8cca73d52b5685035bf8798269e5..235551eb0e7bd23e96f37b4b84adb814c335f924 100644
--- a/third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl
+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl
@@ -4,18 +4,19 @@
// https://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dictionary
+enum FillMode { "none", "forwards", "backwards", "both", "auto" };
+enum PlaybackDirection { "normal", "reverse", "alternate", "alternate-reverse" };
+
// TODO(dstockwell): Rename this to AnimationEffectTimingProperties.
dictionary KeyframeEffectOptions {
double delay = 0;
double endDelay = 0;
- // TODO(dstockwell): The fill type should be FillMode.
- DOMString fill = "auto";
+ FillMode fill = "auto";
double iterationStart = 0.0;
unrestricted double iterations = 1.0;
(unrestricted double or DOMString) duration = "auto";
// TODO(dstockwell): There is no playbackRate member in the spec.
double playbackRate = 1.0;
- // TODO(dstockwell): The direction type should be PlaybackDirection.
- DOMString direction = "normal";
+ PlaybackDirection direction = "normal";
DOMString easing = "linear";
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698