Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1711543002:
Add enums to KeyframeEffectOptions. (Closed)
|
Created:
4 years, 10 months ago by suzyh_UTC10 (ex-contributor) Modified:
4 years, 10 months ago CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd enums to KeyframeEffectOptions.
The KeyframeEffectOptions interface definition used DOMStrings instead
of enums for the "fill" and "direction" members, which differs from the
spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dictionary
This patch converts them to the specified enums.
BUG=
Committed: https://crrev.com/93628b8a585cbe89b2b79577bd7128316fff0c92
Cr-Commit-Position: refs/heads/master@{#376083}
Patch Set 1 #
Messages
Total messages: 31 (17 generated)
suzyh@chromium.org changed reviewers: + shans@chromium.org
suzyh@chromium.org changed reviewers: - shans@chromium.org
The CQ bit was checked by suzyh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
suzyh@chromium.org changed reviewers: + shans@chromium.org
The CQ bit was checked by suzyh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by suzyh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add enums to KeyframeEffectOptions. The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dict... This patch converts them to the specified enums. BUG= ========== to ========== Add enums to KeyframeEffectOptions. The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dict... This patch converts them to the specified enums. BUG= ==========
sergiyb@chromium.org changed reviewers: - sergiyb@chromium.org
dstockwell@chromium.org changed reviewers: + dstockwell@chromium.org
lgtm
The CQ bit was checked by suzyh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711543002/1
Message was sent while issue was closed.
Description was changed from ========== Add enums to KeyframeEffectOptions. The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dict... This patch converts them to the specified enums. BUG= ========== to ========== Add enums to KeyframeEffectOptions. The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dict... This patch converts them to the specified enums. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add enums to KeyframeEffectOptions. The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dict... This patch converts them to the specified enums. BUG= ========== to ========== Add enums to KeyframeEffectOptions. The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dict... This patch converts them to the specified enums. BUG= Committed: https://crrev.com/93628b8a585cbe89b2b79577bd7128316fff0c92 Cr-Commit-Position: refs/heads/master@{#376083} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/93628b8a585cbe89b2b79577bd7128316fff0c92 Cr-Commit-Position: refs/heads/master@{#376083} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
