Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2570)

Unified Diff: content/common/gpu/gpu_channel_manager_unittest.cc

Issue 1711533002: Decouple browser-specific GPU IPC messages from GPU service IPCs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Mark's nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_channel_manager_unittest.cc
diff --git a/content/common/gpu/gpu_channel_manager_unittest.cc b/content/common/gpu/gpu_channel_manager_unittest.cc
index 984de9595f51c3365cffb3bf07008961c1e36ba5..c75750f2a38bf9ba5b4a9d5d0203548ab94fc5da 100644
--- a/content/common/gpu/gpu_channel_manager_unittest.cc
+++ b/content/common/gpu/gpu_channel_manager_unittest.cc
@@ -5,6 +5,7 @@
#include <stddef.h>
#include <stdint.h>
+#include "content/common/gpu/establish_channel_params.h"
#include "content/common/gpu/gpu_channel.h"
#include "content/common/gpu/gpu_channel_manager.h"
#include "content/common/gpu/gpu_channel_test_common.h"
@@ -31,26 +32,20 @@ TEST_F(GpuChannelManagerTest, EstablishChannel) {
ASSERT_TRUE(channel_manager());
- GpuMsg_EstablishChannel_Params params;
+ EstablishChannelParams params;
params.client_id = kClientId;
params.client_tracing_id = kClientTracingId;
params.preempts = false;
params.allow_view_command_buffers = false;
params.allow_real_time_streams = false;
- EXPECT_TRUE(
- channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(params)));
- EXPECT_EQ((size_t)1, sink()->message_count());
- const IPC::Message* msg =
- sink()->GetUniqueMessageMatching(GpuHostMsg_ChannelEstablished::ID);
- ASSERT_TRUE(msg);
- base::Tuple<IPC::ChannelHandle> handle;
- ASSERT_TRUE(GpuHostMsg_ChannelEstablished::Read(msg, &handle));
- EXPECT_NE("", base::get<0>(handle).name);
- sink()->ClearMessages();
+ channel_manager()->EstablishChannel(params);
+ IPC::ChannelHandle handle =
+ channel_manager_delegate()->last_established_channel_handle();
+ EXPECT_NE("", handle.name);
GpuChannel* channel = channel_manager()->LookupChannel(kClientId);
ASSERT_TRUE(channel);
- EXPECT_EQ(base::get<0>(handle).name, channel->channel_id());
+ EXPECT_EQ(handle.name, channel->channel_id());
}
TEST_F(GpuChannelManagerTest, SecureValueStateForwarding) {
@@ -72,31 +67,29 @@ TEST_F(GpuChannelManagerTest, SecureValueStateForwarding) {
ASSERT_TRUE(channel_manager());
// Initialize gpu channels
- GpuMsg_EstablishChannel_Params params;
+ EstablishChannelParams params;
params.client_id = kClientId1;
params.client_tracing_id = kClientTracingId1;
params.preempts = false;
params.allow_view_command_buffers = false;
params.allow_real_time_streams = false;
- EXPECT_TRUE(
- channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(params)));
+ channel_manager()->EstablishChannel(params);
GpuChannel* channel1 = channel_manager()->LookupChannel(kClientId1);
ASSERT_TRUE(channel1);
params.client_id = kClientId2;
params.client_tracing_id = kClientTracingId2;
- EXPECT_TRUE(
- channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(params)));
+ channel_manager()->EstablishChannel(params);
GpuChannel* channel2 = channel_manager()->LookupChannel(kClientId2);
ASSERT_TRUE(channel2);
EXPECT_NE(channel1, channel2);
// Make sure value states are only accessible by proper channels
- channel_manager()->OnMessageReceived(GpuMsg_UpdateValueState(
- kClientId1, GL_MOUSE_POSITION_CHROMIUM, value_state1));
- channel_manager()->OnMessageReceived(GpuMsg_UpdateValueState(
- kClientId2, GL_MOUSE_POSITION_CHROMIUM, value_state2));
+ channel_manager()->UpdateValueState(kClientId1, GL_MOUSE_POSITION_CHROMIUM,
+ value_state1);
+ channel_manager()->UpdateValueState(kClientId2, GL_MOUSE_POSITION_CHROMIUM,
+ value_state2);
const gpu::ValueStateMap* pending_value_buffer_state1 =
channel1->pending_valuebuffer_state();

Powered by Google App Engine
This is Rietveld 408576698