Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: content/browser/gpu/gpu_process_host_ui_shim.cc

Issue 1711533002: Decouple browser-specific GPU IPC messages from GPU service IPCs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Mark's nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/gpu/gpu_process_host_ui_shim.h" 5 #include "content/browser/gpu/gpu_process_host_ui_shim.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
11 #include "base/id_map.h" 11 #include "base/id_map.h"
12 #include "base/lazy_instance.h" 12 #include "base/lazy_instance.h"
13 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
14 #include "base/trace_event/trace_event.h" 14 #include "base/trace_event/trace_event.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "content/browser/compositor/gpu_process_transport_factory.h" 16 #include "content/browser/compositor/gpu_process_transport_factory.h"
17 #include "content/browser/gpu/compositor_util.h" 17 #include "content/browser/gpu/compositor_util.h"
18 #include "content/browser/gpu/gpu_data_manager_impl.h" 18 #include "content/browser/gpu/gpu_data_manager_impl.h"
19 #include "content/browser/gpu/gpu_process_host.h" 19 #include "content/browser/gpu/gpu_process_host.h"
20 #include "content/browser/gpu/gpu_surface_tracker.h" 20 #include "content/browser/gpu/gpu_surface_tracker.h"
21 #include "content/browser/renderer_host/render_process_host_impl.h" 21 #include "content/browser/renderer_host/render_process_host_impl.h"
22 #include "content/browser/renderer_host/render_view_host_impl.h" 22 #include "content/browser/renderer_host/render_view_host_impl.h"
23 #include "content/browser/renderer_host/render_widget_helper.h" 23 #include "content/browser/renderer_host/render_widget_helper.h"
24 #include "content/browser/renderer_host/render_widget_host_view_base.h" 24 #include "content/browser/renderer_host/render_widget_host_view_base.h"
25 #include "content/common/gpu/gpu_messages.h" 25 #include "content/common/gpu/gpu_browser_messages.h"
26 #include "content/public/browser/browser_thread.h" 26 #include "content/public/browser/browser_thread.h"
27 27
28 #if defined(OS_MACOSX) 28 #if defined(OS_MACOSX)
29 #include "ui/accelerated_widget_mac/accelerated_widget_mac.h" 29 #include "ui/accelerated_widget_mac/accelerated_widget_mac.h"
30 #endif 30 #endif
31 31
32 #if defined(USE_OZONE) 32 #if defined(USE_OZONE)
33 #include "ui/ozone/public/gpu_platform_support_host.h" 33 #include "ui/ozone/public/gpu_platform_support_host.h"
34 #include "ui/ozone/public/ozone_platform.h" 34 #include "ui/ozone/public/ozone_platform.h"
35 #endif 35 #endif
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 if (!close_callback_.is_null()) 177 if (!close_callback_.is_null())
178 base::ResetAndReturn(&close_callback_).Run(); 178 base::ResetAndReturn(&close_callback_).Run();
179 g_hosts_by_id.Pointer()->Remove(host_id_); 179 g_hosts_by_id.Pointer()->Remove(host_id_);
180 } 180 }
181 181
182 bool GpuProcessHostUIShim::OnControlMessageReceived( 182 bool GpuProcessHostUIShim::OnControlMessageReceived(
183 const IPC::Message& message) { 183 const IPC::Message& message) {
184 DCHECK(CalledOnValidThread()); 184 DCHECK(CalledOnValidThread());
185 185
186 IPC_BEGIN_MESSAGE_MAP(GpuProcessHostUIShim, message) 186 IPC_BEGIN_MESSAGE_MAP(GpuProcessHostUIShim, message)
187 IPC_MESSAGE_HANDLER(GpuHostMsg_OnLogMessage, 187 IPC_MESSAGE_HANDLER(GpuHostMsg_OnLogMessage, OnLogMessage)
188 OnLogMessage)
189 #if defined(OS_MACOSX) 188 #if defined(OS_MACOSX)
190 IPC_MESSAGE_HANDLER(GpuHostMsg_AcceleratedSurfaceBuffersSwapped, 189 IPC_MESSAGE_HANDLER(GpuHostMsg_AcceleratedSurfaceBuffersSwapped,
191 OnAcceleratedSurfaceBuffersSwapped) 190 OnAcceleratedSurfaceBuffersSwapped)
192 #endif 191 #endif
193 IPC_MESSAGE_HANDLER(GpuHostMsg_GraphicsInfoCollected, 192 IPC_MESSAGE_HANDLER(GpuHostMsg_GraphicsInfoCollected,
194 OnGraphicsInfoCollected) 193 OnGraphicsInfoCollected)
195 IPC_MESSAGE_HANDLER(GpuHostMsg_VideoMemoryUsageStats, 194 IPC_MESSAGE_HANDLER(GpuHostMsg_VideoMemoryUsageStats,
196 OnVideoMemoryUsageStatsReceived); 195 OnVideoMemoryUsageStatsReceived);
197 IPC_MESSAGE_HANDLER(GpuHostMsg_AddSubscription, OnAddSubscription); 196 IPC_MESSAGE_HANDLER(GpuHostMsg_AddSubscription, OnAddSubscription);
198 IPC_MESSAGE_HANDLER(GpuHostMsg_RemoveSubscription, OnRemoveSubscription); 197 IPC_MESSAGE_HANDLER(GpuHostMsg_RemoveSubscription, OnRemoveSubscription);
(...skipping 21 matching lines...) Expand all
220 GpuDataManagerImpl::GetInstance()->UpdateGpuInfo(gpu_info); 219 GpuDataManagerImpl::GetInstance()->UpdateGpuInfo(gpu_info);
221 } 220 }
222 221
223 #if defined(OS_MACOSX) 222 #if defined(OS_MACOSX)
224 void GpuProcessHostUIShim::OnAcceleratedSurfaceBuffersSwapped( 223 void GpuProcessHostUIShim::OnAcceleratedSurfaceBuffersSwapped(
225 const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params) { 224 const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params) {
226 TRACE_EVENT0("browser", 225 TRACE_EVENT0("browser",
227 "GpuProcessHostUIShim::OnAcceleratedSurfaceBuffersSwapped"); 226 "GpuProcessHostUIShim::OnAcceleratedSurfaceBuffersSwapped");
228 if (!ui::LatencyInfo::Verify(params.latency_info, 227 if (!ui::LatencyInfo::Verify(params.latency_info,
229 "GpuHostMsg_AcceleratedSurfaceBuffersSwapped")) { 228 "GpuHostMsg_AcceleratedSurfaceBuffersSwapped")) {
230
231 TRACE_EVENT0("browser", "ui::LatencyInfo::Verify failed"); 229 TRACE_EVENT0("browser", "ui::LatencyInfo::Verify failed");
232 return; 230 return;
233 } 231 }
234 232
235 // On Mac with delegated rendering, accelerated surfaces are not necessarily 233 // On Mac with delegated rendering, accelerated surfaces are not necessarily
236 // associated with a RenderWidgetHostViewBase. 234 // associated with a RenderWidgetHostViewBase.
237 AcceleratedSurfaceMsg_BufferPresented_Params ack_params; 235 AcceleratedSurfaceMsg_BufferPresented_Params ack_params;
238 236
239 // If the frame was intended for an NSView that the gfx::AcceleratedWidget is 237 // If the frame was intended for an NSView that the gfx::AcceleratedWidget is
240 // no longer attached to, do not pass the frame along to the widget. Just ack 238 // no longer attached to, do not pass the frame along to the widget. Just ack
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 284
287 void GpuProcessHostUIShim::OnRemoveSubscription(int32_t process_id, 285 void GpuProcessHostUIShim::OnRemoveSubscription(int32_t process_id,
288 unsigned int target) { 286 unsigned int target) {
289 RenderProcessHost* rph = RenderProcessHost::FromID(process_id); 287 RenderProcessHost* rph = RenderProcessHost::FromID(process_id);
290 if (rph) { 288 if (rph) {
291 rph->OnRemoveSubscription(target); 289 rph->OnRemoveSubscription(target);
292 } 290 }
293 } 291 }
294 292
295 } // namespace content 293 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698