Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171153003: Catch EXCEPTION_IN_PAGE_ERROR errors in SafeGetImageInfo (Closed)

Created:
6 years, 10 months ago by csharp
Modified:
6 years, 10 months ago
Reviewers:
robertshield
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Catch EXCEPTION_IN_PAGE_ERROR errors in SafeGetImageInfo It is ok for SafeGetImageInfo to fails to get the image info, so catch exceptions instead of dying. BUG=343925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252062

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome_elf/blacklist/blacklist_interceptions.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
csharp
6 years, 10 months ago (2014-02-18 21:31:11 UTC) #1
robertshield
lgtm https://codereview.chromium.org/171153003/diff/1/chrome_elf/blacklist/blacklist_interceptions.cc File chrome_elf/blacklist/blacklist_interceptions.cc (right): https://codereview.chromium.org/171153003/diff/1/chrome_elf/blacklist/blacklist_interceptions.cc#newcode152 chrome_elf/blacklist/blacklist_interceptions.cc:152: GetExceptionCode() == EXCEPTION_IN_PAGE_ERROR ) ? nit: no space ...
6 years, 10 months ago (2014-02-18 23:32:24 UTC) #2
csharp
https://codereview.chromium.org/171153003/diff/1/chrome_elf/blacklist/blacklist_interceptions.cc File chrome_elf/blacklist/blacklist_interceptions.cc (right): https://codereview.chromium.org/171153003/diff/1/chrome_elf/blacklist/blacklist_interceptions.cc#newcode152 chrome_elf/blacklist/blacklist_interceptions.cc:152: GetExceptionCode() == EXCEPTION_IN_PAGE_ERROR ) ? On 2014/02/18 23:32:24, robertshield ...
6 years, 10 months ago (2014-02-19 13:13:30 UTC) #3
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 10 months ago (2014-02-19 13:13:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/171153003/110001
6 years, 10 months ago (2014-02-19 13:13:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/171153003/110001
6 years, 10 months ago (2014-02-19 15:01:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/171153003/110001
6 years, 10 months ago (2014-02-19 15:29:42 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 20:23:11 UTC) #8
Message was sent while issue was closed. 
Change committed as 252062

Powered by Google App Engine
This is Rietveld 408576698