Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 171153002: Increase Browser Blacklist (Closed)

Created:
6 years, 10 months ago by csharp
Modified:
6 years, 10 months ago
CC:
chromium-reviews, caitkp+watch_chromium.org
Visibility:
Public.

Description

Increase Browser Blacklist Begin blacklisting datamngr.dl, lmrn.dll and hk.dll from the browser process. BUG=329023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251886

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome_elf/blacklist/blacklist.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
csharp
lmnr.dll is causing the most crashes of these three. It looks like it might be ...
6 years, 10 months ago (2014-02-18 19:12:58 UTC) #1
robertshield
lgtm https://codereview.chromium.org/171153002/diff/1/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/171153002/diff/1/chrome_elf/blacklist/blacklist.cc#newcode26 chrome_elf/blacklist/blacklist.cc:26: L"libsvn_tsvn32.dll", nit: this list should be alphabetized
6 years, 10 months ago (2014-02-18 19:37:00 UTC) #2
csharp
https://codereview.chromium.org/171153002/diff/1/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/171153002/diff/1/chrome_elf/blacklist/blacklist.cc#newcode26 chrome_elf/blacklist/blacklist.cc:26: L"libsvn_tsvn32.dll", On 2014/02/18 19:37:00, robertshield wrote: > nit: this ...
6 years, 10 months ago (2014-02-18 19:39:34 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm It would be nice (in another CL) if you like to have the right ...
6 years, 10 months ago (2014-02-18 20:08:17 UTC) #4
csharp
On 2014/02/18 20:08:17, cpu wrote: > lgtm > > It would be nice (in another ...
6 years, 10 months ago (2014-02-18 21:40:56 UTC) #5
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 10 months ago (2014-02-18 21:40:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/171153002/140001
6 years, 10 months ago (2014-02-18 21:42:18 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 00:03:05 UTC) #8
Message was sent while issue was closed.
Change committed as 251886

Powered by Google App Engine
This is Rietveld 408576698