Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711513003: Fix FunctionTester constructor from given parameter count. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix FunctionTester constructor from given parameter count. Committed: https://crrev.com/2225546f55c7e9644f78a263b8841660c7d2ec6a Cr-Commit-Position: refs/heads/master@{#34103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M test/cctest/compiler/function-tester.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-18 09:03:01 UTC) #2
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-18 09:06:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711513003/1
4 years, 10 months ago (2016-02-18 09:06:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:28:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:28:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2225546f55c7e9644f78a263b8841660c7d2ec6a
Cr-Commit-Position: refs/heads/master@{#34103}

Powered by Google App Engine
This is Rietveld 408576698