Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17115010: Add support for element blending to SVG (Closed)

Created:
7 years, 6 months ago by Rik
Modified:
7 years, 5 months ago
Reviewers:
pdr., krit, Stephen Chennney
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, mitica
Visibility:
Public.

Description

First submission for support of blending in SVG + added a number of ref tests that show all blend modes and test conditions for isolation. The CSS property is already parsed and stored (mix-blend-mode) and the blend mode themselves are already implemented in skia. Launch bug is http://crbug.com/229615 BUG=260927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154607

Patch Set 1 #

Patch Set 2 : updated patch with more test files #

Total comments: 12

Patch Set 3 : updated test files #

Total comments: 2

Patch Set 4 : more spaces removed #

Total comments: 1

Patch Set 5 : added test file with alpha and blending at the same time #

Patch Set 6 : Added test files for webkit-svg-shadow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1003 lines, -2 lines) Patch
A LayoutTests/css3/compositing/svg-blend-color.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-color-burn.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-color-burn-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-color-dodge.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-color-dodge-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-color-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-darken.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-darken-expected.html View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-difference.html View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-difference-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-exclusion.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-exclusion-expected.html View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-hard-light.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-hard-light-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-hue.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-hue-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-blend.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-blend-expected.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-filter.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-filter-expected.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-mask.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-mask-expected.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-opacity.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-opacity-expected.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-shadow.html View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-layer-shadow-expected.html View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-lighten.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-lighten-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-luminosity.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-luminosity-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-multiply.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-multiply-alpha.html View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-multiply-alpha-expected.html View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-multiply-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-multiply-shadow.html View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-multiply-shadow-expected.html View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-normal.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-normal-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-overlay.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-overlay-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-saturation.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-saturation-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-screen.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-screen-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-soft-light.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-soft-light-expected.html View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
krit
I think the code looks good. I need a bit more time to review the ...
7 years, 6 months ago (2013-06-20 18:31:46 UTC) #1
Rik
On 2013/06/20 18:31:46, krit wrote: > I think the code looks good. I need a ...
7 years, 6 months ago (2013-06-21 02:38:48 UTC) #2
Rik
7 years, 6 months ago (2013-06-21 02:38:58 UTC) #3
pdr.
Quite nice tests overall. Mostly just nits. https://codereview.chromium.org/17115010/diff/8001/LayoutTests/css3/compositing/svg-blend-color-burn-expected.html File LayoutTests/css3/compositing/svg-blend-color-burn-expected.html (right): https://codereview.chromium.org/17115010/diff/8001/LayoutTests/css3/compositing/svg-blend-color-burn-expected.html#newcode16 LayoutTests/css3/compositing/svg-blend-color-burn-expected.html:16: <rect id="r" ...
7 years, 5 months ago (2013-07-17 22:17:23 UTC) #4
pdr.
Quite nice tests overall. Mostly just nits.
7 years, 5 months ago (2013-07-17 22:17:24 UTC) #5
pdr.
Tests look good now. https://codereview.chromium.org/17115010/diff/19001/LayoutTests/css3/compositing/svg-blend-color-burn-expected.html File LayoutTests/css3/compositing/svg-blend-color-burn-expected.html (right): https://codereview.chromium.org/17115010/diff/19001/LayoutTests/css3/compositing/svg-blend-color-burn-expected.html#newcode7 LayoutTests/css3/compositing/svg-blend-color-burn-expected.html:7: <rect x="0" y="0" width="10" height="10" ...
7 years, 5 months ago (2013-07-18 02:16:52 UTC) #6
pdr.
LGTM with a request for one more test. https://codereview.chromium.org/17115010/diff/54001/Source/core/rendering/svg/SVGRenderingContext.cpp File Source/core/rendering/svg/SVGRenderingContext.cpp (right): https://codereview.chromium.org/17115010/diff/54001/Source/core/rendering/svg/SVGRenderingContext.cpp#newcode123 Source/core/rendering/svg/SVGRenderingContext.cpp:123: if ...
7 years, 5 months ago (2013-07-18 22:24:47 UTC) #7
Rik
On 2013/07/18 22:24:47, pdr wrote: > LGTM with a request for one more test. > ...
7 years, 5 months ago (2013-07-18 22:41:50 UTC) #8
pdr.
On 2013/07/18 22:41:50, Rik wrote: > On 2013/07/18 22:24:47, pdr wrote: > > LGTM with ...
7 years, 5 months ago (2013-07-18 22:58:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cabanier@adobe.com/17115010/64001
7 years, 5 months ago (2013-07-19 18:52:02 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=204
7 years, 5 months ago (2013-07-20 01:09:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cabanier@adobe.com/17115010/64001
7 years, 5 months ago (2013-07-20 02:25:01 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=266
7 years, 5 months ago (2013-07-20 09:02:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cabanier@adobe.com/17115010/64001
7 years, 5 months ago (2013-07-21 05:40:43 UTC) #14
commit-bot: I haz the power
Change committed as 154607
7 years, 5 months ago (2013-07-21 06:54:53 UTC) #15
krit
Rik, did you add the -webkit-svg-shadow test? I couldn't find it. pdr, Apple doesn't want ...
7 years, 5 months ago (2013-07-22 05:58:45 UTC) #16
krit
On 2013/07/18 22:41:50, Rik wrote: > Per IRC chat, we shouldn't test for -webkit-svg-shadow as ...
7 years, 5 months ago (2013-07-22 06:00:33 UTC) #17
pdr.
On 2013/07/22 05:58:45, krit wrote: > Rik, did you add the -webkit-svg-shadow test? I couldn't ...
7 years, 5 months ago (2013-07-22 06:50:14 UTC) #18
Rik
7 years, 5 months ago (2013-07-22 19:21:05 UTC) #19
Message was sent while issue was closed. 
On 2013/07/22 05:58:45, krit wrote:
> Rik, did you add the -webkit-svg-shadow test? I couldn't find it.
> 
> pdr, Apple doesn't want to remove -webkit-svg-shadow and filter does not
support
> multiple drop-shadows yet. Do we still want to investigate if we can remove
this
> code? I do not expect that this is actively used by something else than Apple
> applications.

yes, look at the test files with 'shadow' in the name

Powered by Google App Engine
This is Rietveld 408576698