Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1711483004: Replace use of SkTDArray with std::vector in font code. (Closed)

Created:
4 years, 10 months ago by bungeman-chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace use of SkTDArray with std::vector in font code. The initial motivation is that Skia is interested in making SkTDArray internal. Using std::vector is also clearer, more idiomatic, and safer. SkString is already the size of a pointer and is movable (to avoid internal reference count churn). Committed: https://crrev.com/e27534c2fc4263fca7f4686bc8b75bb7a319d0b3 Cr-Commit-Position: refs/heads/master@{#376175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M components/font_service/font_service_app.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711483004/1
4 years, 10 months ago (2016-02-18 00:35:43 UTC) #2
bungeman-chromium
4 years, 10 months ago (2016-02-18 01:18:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 01:21:41 UTC) #7
Jorge Lucangeli Obes
content/browser/renderer_host/sandbox_ipc_linux.* lgtm
4 years, 10 months ago (2016-02-18 01:38:08 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-18 15:15:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711483004/1
4 years, 10 months ago (2016-02-18 15:51:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 15:58:48 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 16:00:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e27534c2fc4263fca7f4686bc8b75bb7a319d0b3
Cr-Commit-Position: refs/heads/master@{#376175}

Powered by Google App Engine
This is Rietveld 408576698