Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1711483003: Process events from ChromeVox Panel again. (Closed)

Created:
4 years, 10 months ago by David Tseng
Modified:
4 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Process events from ChromeVox Panel again. Previously, the panel caused some flakeyness in the interactive ui tests. Try re-enabling again. Committed: https://crrev.com/0f32e520cad7de8da5d0d4407c34936e6adead7b Cr-Commit-Position: refs/heads/master@{#376046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
David Tseng
4 years, 10 months ago (2016-02-17 23:04:38 UTC) #3
dmazzoni
lgtm
4 years, 10 months ago (2016-02-18 00:07:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711483003/1
4 years, 10 months ago (2016-02-18 00:08:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 00:16:24 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 00:17:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f32e520cad7de8da5d0d4407c34936e6adead7b
Cr-Commit-Position: refs/heads/master@{#376046}

Powered by Google App Engine
This is Rietveld 408576698