Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1711433002: Deprecate old "isPotentiallyMutated..." API. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate old "isPotentiallyMutated..." API. The getters are rewritten to return `true`. Technically this is not a breaking change, since all variables are "potentially mutated" in at least a vacuous sense. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4eaafd3ee5cccb40edd49c0a374d94d638f9f11c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -77 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 7 chunks +8 lines, -56 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -19 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-17 19:33:26 UTC) #2
Brian Wilkerson
LGTM. Should we update the version number (to an alpha version) now or later?
4 years, 10 months ago (2016-02-17 20:22:49 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-17 20:37:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4eaafd3ee5cccb40edd49c0a374d94d638f9f11c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698