Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 17114008: cc: Remove cc::Thread and cc::ThreadImpl. (Closed)

Created:
7 years, 6 months ago by danakj
Modified:
7 years, 6 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, cc-bugs_chromium.org, backer, brianderson, nduca
Visibility:
Public.

Description

cc: Remove cc::Thread and cc::ThreadImpl. These classes are replaced by using base::SingleThreadTaskRunner directly. R=piman,jamesr BUG=251134 Depends on: https://codereview.chromium.org/17362002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207491

Patch Set 1 #

Patch Set 2 : rm-thread: clarify threads in UpdateBackgroundAnimateTicking, test asserts #

Total comments: 4

Patch Set 3 : rm-thread: rebase #

Patch Set 4 : rm-thread: fix embedder to use MLProxy #

Patch Set 5 : rm-thread: fixDRTbuild #

Patch Set 6 : rm-thread: win bools|android #

Patch Set 7 : rm-thread: gutted #

Total comments: 2

Patch Set 8 : rm-thread: NULLrefptrs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -386 lines) Patch
D cc/base/thread.h View 1 chunk +0 lines, -36 lines 0 comments Download
D cc/base/thread_impl.h View 1 chunk +0 lines, -44 lines 0 comments Download
D cc/base/thread_impl.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M cc/cc.gyp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.cc View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -6 lines 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M cc/resources/prioritized_resource_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/resource_update_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler/rate_limiter.h View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/scheduler/rate_limiter.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_impl_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_proxy.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 9 chunks +36 lines, -26 lines 0 comments Download
M cc/test/scheduler_test_common.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 5 6 7 11 chunks +16 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 5 chunks +11 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/proxy.h View 1 2 4 chunks +9 lines, -10 lines 0 comments Download
M cc/trees/proxy.cc View 1 2 3 4 5 3 chunks +18 lines, -19 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 4 5 6 7 3 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 34 chunks +97 lines, -59 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 5 2 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 2 chunks +1 line, -8 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_compositor_support_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M webkit/support/web_layer_tree_view_impl_for_testing.h View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M webkit/support/web_layer_tree_view_impl_for_testing.cc View 1 2 3 4 5 6 7 3 chunks +2 lines, -6 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
danakj
7 years, 6 months ago (2013-06-18 04:21:04 UTC) #1
piman
lgtm https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc File cc/layers/delegated_renderer_layer_impl_unittest.cc (right): https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc#newcode36 cc/layers/delegated_renderer_layer_impl_unittest.cc:36: : proxy_(), nit: remove redundant default initializer. https://codereview.chromium.org/17114008/diff/8001/cc/resources/resource_update_controller_unittest.cc ...
7 years, 6 months ago (2013-06-18 17:56:25 UTC) #2
danakj
https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc File cc/layers/delegated_renderer_layer_impl_unittest.cc (right): https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc#newcode36 cc/layers/delegated_renderer_layer_impl_unittest.cc:36: : proxy_(), On 2013/06/18 17:56:25, piman wrote: > nit: ...
7 years, 6 months ago (2013-06-18 18:00:31 UTC) #3
piman
On Tue, Jun 18, 2013 at 11:00 AM, <danakj@chromium.org> wrote: > > https://codereview.chromium.**org/17114008/diff/8001/cc/** > layers/delegated_renderer_**layer_impl_unittest.cc<https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc> ...
7 years, 6 months ago (2013-06-18 18:09:24 UTC) #4
danakj
On Tue, Jun 18, 2013 at 2:09 PM, Antoine Labour <piman@chromium.org> wrote: > On Tue, ...
7 years, 6 months ago (2013-06-18 18:14:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/15001
7 years, 6 months ago (2013-06-19 00:46:46 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-19 01:11:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/35001
7 years, 6 months ago (2013-06-19 01:22:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=10139
7 years, 6 months ago (2013-06-19 01:37:43 UTC) #9
danakj
TBR=jamesr to remove unused header file
7 years, 6 months ago (2013-06-19 01:38:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/35001
7 years, 6 months ago (2013-06-19 01:38:57 UTC) #11
danakj
I take back that TBR. jamesr@ please take a look at webkit/ as I had ...
7 years, 6 months ago (2013-06-19 02:11:21 UTC) #12
jamesr
DRT doesn't build any more. The only thing using WLTVForTesting are a small set of ...
7 years, 6 months ago (2013-06-19 05:17:08 UTC) #13
danakj
On Wed, Jun 19, 2013 at 1:17 AM, <jamesr@chromium.org> wrote: > DRT doesn't build any ...
7 years, 6 months ago (2013-06-19 15:28:59 UTC) #14
jamesr
webkit/ lgtm https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_support.cc File webkit/support/webkit_support.cc (right): https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_support.cc#newcode466 webkit/support/webkit_support.cc:466: DCHECK(thread == NULL); why not DCHECK_EQ, DCHECK(!thread), ...
7 years, 6 months ago (2013-06-19 17:33:40 UTC) #15
danakj
Thanks! https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_support.cc File webkit/support/webkit_support.cc (right): https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_support.cc#newcode466 webkit/support/webkit_support.cc:466: DCHECK(thread == NULL); On 2013/06/19 17:33:41, jamesr wrote: ...
7 years, 6 months ago (2013-06-19 17:37:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/72001
7 years, 6 months ago (2013-06-19 17:47:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/33003
7 years, 6 months ago (2013-06-19 17:49:45 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=166304
7 years, 6 months ago (2013-06-20 07:14:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/33003
7 years, 6 months ago (2013-06-20 15:01:29 UTC) #20
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 18:26:20 UTC) #21
Message was sent while issue was closed.
Change committed as 207491

Powered by Google App Engine
This is Rietveld 408576698