chrome/browser/search/instant_service.cc - Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/instant_service.cc

Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/most_visited_tiles_experiment_unittest.cc ('K') | « chrome/browser/history/top_sites.cc ('k') | chrome/browser/ui/search/instant_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/instant_service.cc

diff --git a/chrome/browser/search/instant_service.cc b/chrome/browser/search/instant_service.cc

index 014cbf806e7c13437bcaf7d9be0559b7a8385a91..d3763b03d1fe9d4713174082a2bb2ec51b4e4bb6 100644

--- a/chrome/browser/search/instant_service.cc

+++ b/chrome/browser/search/instant_service.cc

@@ -10,6 +10,7 @@

#include "base/strings/string_number_conversions.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/history/history_notifications.h"

+#include "chrome/browser/history/most_visited_tiles_experiment.h"

#include "chrome/browser/history/top_sites.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search/instant_io_context.h"

@@ -249,7 +250,7 @@ void InstantService::Observe(int type,

void InstantService::OnMostVisitedItemsReceived(

const history::MostVisitedURLList& data) {

history::MostVisitedURLList reordered_data(data);

- history::TopSites::MaybeShuffle(&reordered_data);

+ history::MostVisitedTilesExperiment::MaybeShuffle(&reordered_data);

std::vector<InstantMostVisitedItem> new_most_visited_items;

for (size_t i = 0; i < reordered_data.size(); i++) {