chrome/browser/ui/webui/ntp/most_visited_handler.h - Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.h

Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Consolidated GetOpenURLs and addressed comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/tabs/tab_strip_model_utils.cc ('K') | « chrome/browser/ui/tabs/tab_strip_model_utils.cc ('k') | chrome/browser/ui/webui/ntp/most_visited_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/most_visited_handler.h

diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.h b/chrome/browser/ui/webui/ntp/most_visited_handler.h

index 37f20e1eea7db7cd50262468cb4a70aac0ca7a38..fe5784a82b362bd7c6825a1a6ecb0d16e3e53f49 100644

--- a/chrome/browser/ui/webui/ntp/most_visited_handler.h

+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.h

@@ -90,9 +90,10 @@ class MostVisitedHandler : public content::WebUIMessageHandler,

// Returns the key used in url_blacklist_ for the passed |url|.

std::string GetDictionaryKeyForUrl(const std::string& url);

- // Looks at the browser's currently open URLs and removes any matching URLs

- // from |pages_value_|.

- void RemovePageValuesMatchingOpenTabs();

+ // Removes recommended URLs if a matching URL is already open in the Browser,

+ // if the Most Visited Tile Placement experiment is enabled, and the client is

+ // in the experiment group.

+ void MaybeRemovePageValues();

// Sends pages_value_ to the javascript side and resets page_value_.

void SendPagesValue();