chrome/browser/ui/webui/ntp/most_visited_handler.h - Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.h

Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/search/instant_controller.h ('K') | « chrome/browser/ui/search/instant_controller.cc ('k') | chrome/browser/ui/webui/ntp/most_visited_handler.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/most_visited_handler.h

diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.h b/chrome/browser/ui/webui/ntp/most_visited_handler.h

index 0fc412655d921dbcee216974eb6ad940d44800f7..50c763b27ef2d76181f5abb649ac4c916f4d913c 100644

--- a/chrome/browser/ui/webui/ntp/most_visited_handler.h

+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.h

@@ -90,9 +90,9 @@ class MostVisitedHandler : public content::WebUIMessageHandler,

// Returns the key used in url_blacklist_ for the passed |url|.

std::string GetDictionaryKeyForUrl(const std::string& url);

- // Looks at the browser's currently open URLs and removes any matching URLs

- // from |pages_value_|.

- void RemovePageValuesMatchingOpenTabs();

+ // Experiment that removes recommended URLs if a matching URL is already open

+ // in the Browser.

beaudoin 2013/06/20 21:55:44 Same here.

annark1 2013/07/04 18:29:15 Done.

+ void MaybeRemovePageValues();

// Sends pages_value_ to the javascript side and resets page_value_.

void SendPagesValue();