Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1711353003: update setAnalysisRoots to accept package spec file (Closed)

Created:
4 years, 10 months ago by danrubel
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update setAnalysisRoots to accept package spec file As part of addressing https://github.com/dartino/atom-dartino/issues/13, this CL updates the setAnalysisRoots API to allow package spec files in the packageRoots map. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9fe92127e560a4b9b9434125d1c6ec90f2d6890f

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -36 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +15 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 2 chunks +26 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +13 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +11 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 10 months ago (2016-02-19 13:13:12 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-19 14:50:55 UTC) #3
danrubel
4 years, 10 months ago (2016-02-19 15:57:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9fe92127e560a4b9b9434125d1c6ec90f2d6890f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698