tests/PictureTest.cpp - Issue 17113004: Replace SkPicture(SkStream) constructors with a factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureTest.cpp

Issue 17113004: Replace SkPicture(SkStream) constructors with a factory. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Remove dead function declaration. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index 23ff6893c0f4d867fb7d1754c5ba6e75d1e2d99f..49bc57b1af29960e5cafa0cc709440d2171f0559 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -420,10 +420,9 @@ static void test_bitmap_with_encoded_data(skiatest::Reporter* reporter) {

context.fReporter = reporter;

SkSetErrorCallback(assert_one_parse_error_cb, &context);

SkMemoryStream pictureStream(picture1);

- bool success;

SkClearLastError();

- SkPicture pictureFromStream(&pictureStream, &success, NULL);

- REPORTER_ASSERT(reporter, success);

+ SkAutoUnref pictureFromStream(SkPicture::CreateFromStream(&pictureStream, NULL));

+ REPORTER_ASSERT(reporter, pictureFromStream.get() != NULL);

SkClearLastError();

SkSetErrorCallback(NULL, NULL);

}