tools/filtermain.cpp - Issue 17113004: Replace SkPicture(SkStream) constructors with a factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/filtermain.cpp

Issue 17113004: Replace SkPicture(SkStream) constructors with a factory. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Remove a change in behavior Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/filtermain.cpp

diff --git a/tools/filtermain.cpp b/tools/filtermain.cpp

index 4114a9db41ddec13b7af5d297d6b070faa864cc6..39c484d7243dd763d0466bb2c03758bc9c283db3 100644

--- a/tools/filtermain.cpp

+++ b/tools/filtermain.cpp

@@ -666,7 +666,7 @@ static int filter_picture(const SkString& inFile, const SkString& outFile) {

SkFILEStream inStream(inFile.c_str());

if (inStream.isValid()) {

- inPicture.reset(SkNEW_ARGS(SkPicture, (&inStream, NULL, &SkImageDecoder::DecodeMemory)));

+ inPicture.reset(SkPicture::CreateFromStream(&inStream));

}

if (NULL == inPicture.get()) {

« no previous file with comments | « tools/bench_pictures_main.cpp ('k') | tools/lua/lua_pictures.cpp » ('j') | no next file with comments »