build/config/android/internal_rules.gni - Issue 1711253002: Make _incremental targets work with emma_coverage=true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/internal_rules.gni

Issue 1711253002: Make _incremental targets work with emma_coverage=true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/internal_rules.gni

diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni

index 952f78aa3f18f32da80cd31ef2fc79c219702e78..0006a1bfc014244deef620bb72420301c0640c97 100644

--- a/build/config/android/internal_rules.gni

+++ b/build/config/android/internal_rules.gni

@@ -310,7 +310,8 @@ template("dex") {

args += [ "--incremental" ]

}

- if (defined(invoker.no_locals) && invoker.no_locals) {

+ # EMMA requires --no-locals.

+ if (emma_coverage) {

args += [ "--no-locals=1" ]

}

@@ -1743,7 +1744,6 @@ template("java_library_impl") {

_jar_path,

]

output = _dex_path

- no_locals = _emma_instrument

deps = [

":$_compile_java_target",

]

« no previous file with comments | « build/android/incremental_install/BUILD.gn ('k') | build/config/android/rules.gni » ('j') | no next file with comments »