Make _incremental targets work with emma_coverage=true

Make _incremental targets work with emma_coverage=true

BUG=587986
Committed: https://crrev.com/9a6ba5e0f6a2c6a5626d9203ca6cd6497aa5cb45
Cr-Commit-Position: refs/heads/master@{#378251}

[agrieve, 2016-02-19 01:20:22]

Description was changed from

==========
Make _incremental targets work with emma_coverage=true

BUG=587986
==========

to

==========
Make _incremental targets work with emma_coverage=true

BUG=587986
==========

[agrieve, 2016-02-19 01:20:22]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-02-19 01:20:41]

On 2016/02/19 01:20:22, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

🔌

[agrieve, 2016-02-19 01:21:03]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 01:22:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711253002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711253002/1

[commit-bot: I haz the power, 2016-02-19 02:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 02:08:35]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-02-22 00:43:03]

https://codereview.chromium.org/1711253002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1711253002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1452: if (emma_coverage &&
!_emma_never_instrument) {
Why'd you move this into write_build_config?

[agrieve, 2016-02-23 02:59:12]

https://codereview.chromium.org/1711253002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1711253002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1452: if (emma_coverage &&
!_emma_never_instrument) {
On 2016/02/22 00:43:03, jbudorick - slow til Feb 25 wrote:
> Why'd you move this into write_build_config?

It's the thing that records your classpath based on your deps. Added a code
comment.

[agrieve, 2016-02-29 18:23:06]

On 2016/02/23 02:59:12, agrieve wrote:
>
https://codereview.chromium.org/1711253002/diff/1/build/config/android/rules.gni
> File build/config/android/rules.gni (right):
> 
>
https://codereview.chromium.org/1711253002/diff/1/build/config/android/rules....
> build/config/android/rules.gni:1452: if (emma_coverage &&
> !_emma_never_instrument) {
> On 2016/02/22 00:43:03, jbudorick - slow til Feb 25 wrote:
> > Why'd you move this into write_build_config?
> 
> It's the thing that records your classpath based on your deps. Added a code
> comment.

nudge

[jbudorick, 2016-02-29 18:31:59]

lgtm

[agrieve, 2016-02-29 19:19:46]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-29 19:20:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711253002/20001

[commit-bot: I haz the power, 2016-02-29 20:06:23]

Description was changed from

==========
Make _incremental targets work with emma_coverage=true

BUG=587986
==========

to

==========
Make _incremental targets work with emma_coverage=true

BUG=587986
==========

[commit-bot: I haz the power, 2016-02-29 20:06:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-29 20:07:35]

Description was changed from

==========
Make _incremental targets work with emma_coverage=true

BUG=587986
==========

to

==========
Make _incremental targets work with emma_coverage=true

BUG=587986

Committed: https://crrev.com/9a6ba5e0f6a2c6a5626d9203ca6cd6497aa5cb45
Cr-Commit-Position: refs/heads/master@{#378251}
==========

[commit-bot: I haz the power, 2016-02-29 20:07:36]

Patchset 2 (id:??) landed as
https://crrev.com/9a6ba5e0f6a2c6a5626d9203ca6cd6497aa5cb45
Cr-Commit-Position: refs/heads/master@{#378251}