Switch inactive tab highlight color from "white" to "active tab color".

Switch inactive tab highlight color from "white" to "active tab color".

This looks significantly better in dark themes (e.g. MD incognito).

As part of this, raised the opacity from 25% back to 45%.  (I came down from 50%
originally to tone down the effect so as to make MD incognito tabs not look
awful, but Sebastien still didn't like it, and this is a better fix anyway.  I
also had originally reduced the diameter of the hover effect; that change is
kept.)

BUG=584372
TEST=Run with --top-chrome-md=material, open an incognito window, add more tabs, hover background tabs, and ensure the portion of the hover highlight that tracks the tip of the mouse cursor is subtle and not a bright white.

Committed: https://crrev.com/42b2a447258510d20b704550568c99d20376425d
Cr-Commit-Position: refs/heads/master@{#377285}

[Peter Kasting, 2016-02-19 00:46:14]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-02-19 19:09:59]

LGTM

https://codereview.chromium.org/1711233002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/1711233002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:1290: const int a =
pinned_title_change_animation_->CurrentValueBetween(255, 0);
nit: use alpha, 'a' isn't really that obvious.

[Peter Kasting, 2016-02-24 12:29:01]

https://codereview.chromium.org/1711233002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/1711233002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:1290: const int a =
pinned_title_change_animation_->CurrentValueBetween(255, 0);
On 2016/02/19 19:09:59, sky wrote:
> nit: use alpha, 'a' isn't really that obvious.

Done.

[Peter Kasting, 2016-02-24 13:59:22]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-02-24 13:59:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1711233002/#ps20001
(title: "Review comment")

[commit-bot: I haz the power, 2016-02-24 14:00:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711233002/20001

[commit-bot: I haz the power, 2016-02-24 14:08:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 14:10:10]

Description was changed from

==========
Switch inactive tab highlight color from "white" to "active tab color".

This looks significantly better in dark themes (e.g. MD incognito).

As part of this, raised the opacity from 25% back to 45%.  (I came down from 50%
originally to tone down the effect so as to make MD incognito tabs not look
awful, but Sebastien still didn't like it, and this is a better fix anyway.  I
also had originally reduced the diameter of the hover effect; that change is
kept.)

BUG=584372
TEST=Run with --top-chrome-md=material, open an incognito window, add more tabs,
hover background tabs, and ensure the portion of the hover highlight that tracks
the tip of the mouse cursor is subtle and not a bright white.
==========

to

==========
Switch inactive tab highlight color from "white" to "active tab color".

This looks significantly better in dark themes (e.g. MD incognito).

As part of this, raised the opacity from 25% back to 45%.  (I came down from 50%
originally to tone down the effect so as to make MD incognito tabs not look
awful, but Sebastien still didn't like it, and this is a better fix anyway.  I
also had originally reduced the diameter of the hover effect; that change is
kept.)

BUG=584372
TEST=Run with --top-chrome-md=material, open an incognito window, add more tabs,
hover background tabs, and ensure the portion of the hover highlight that tracks
the tip of the mouse cursor is subtle and not a bright white.

Committed: https://crrev.com/42b2a447258510d20b704550568c99d20376425d
Cr-Commit-Position: refs/heads/master@{#377285}
==========

[commit-bot: I haz the power, 2016-02-24 14:10:11]

Patchset 2 (id:??) landed as
https://crrev.com/42b2a447258510d20b704550568c99d20376425d
Cr-Commit-Position: refs/heads/master@{#377285}