Only use fake gamma with linear devices.

Only use fake gamma with linear devices.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711223003

Committed: https://skia.googlesource.com/skia/+/f6d1e605317917146362706ed460b5ed6624fcc5

[bungeman-skia, 2016-02-19 20:47:17]

Description was changed from

==========
Only use fake gamma with linear devices.
==========

to

==========
Only use fake gamma with linear devices.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-02-19 20:47:48]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 20:47:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711223003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711223003/1

[bungeman-skia, 2016-02-19 20:57:40]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 20:57:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711223003/20001

[bungeman-skia, 2016-02-19 20:58:25]

bungeman@google.com changed reviewers:
+ reed@google.com

[bungeman-skia, 2016-02-19 21:00:54]

bungeman@google.com changed reviewers:
+ jvanverth@google.com

[reed1, 2016-02-19 21:21:05]

lgtm

[reed1, 2016-02-19 21:21:09]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-02-19 21:21:15]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-02-19 21:21:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711223003/20001

[jvanverth1, 2016-02-19 21:27:38]

It's not clear to me how this will affect distance field text's gamma
adjustment. I'll try to take a closer look tonight.

[reed1, 2016-02-19 21:28:21]

The CQ bit was unchecked by reed@google.com

[bungeman-skia, 2016-02-19 21:32:59]

On 2016/02/19 21:27:38, jvanverth1 wrote:
> It's not clear to me how this will affect distance field text's gamma
> adjustment. I'll try to take a closer look tonight.

This shouldn't change behavior, the changes to the gpu code just replace the
'true' and 'false' with 'FakeGamma::Off' and 'FakeGamma:On', respectively. The
distance field code was passing 'true' and is now passing 'FakeGamma::Off',
which I think is a little clearer (it doesn't want fake gamma applied).

[bungeman-skia, 2016-02-22 20:48:08]

On 2016/02/19 21:32:59, bungeman1 wrote:
> On 2016/02/19 21:27:38, jvanverth1 wrote:
> > It's not clear to me how this will affect distance field text's gamma
> > adjustment. I'll try to take a closer look tonight.
> 
> This shouldn't change behavior, the changes to the gpu code just replace the
> 'true' and 'false' with 'FakeGamma::Off' and 'FakeGamma:On', respectively. The
> distance field code was passing 'true' and is now passing 'FakeGamma::Off',
> which I think is a little clearer (it doesn't want fake gamma applied).

No changes is gold, so I'm assuming I got all the logic the right way around.

[bungeman-skia, 2016-02-22 20:48:15]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-02-22 20:48:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711223003/20001

[commit-bot: I haz the power, 2016-02-22 21:20:32]

Description was changed from

==========
Only use fake gamma with linear devices.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Only use fake gamma with linear devices.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f6d1e605317917146362706ed460b5ed6624fcc5
==========

[commit-bot: I haz the power, 2016-02-22 21:20:33]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f6d1e605317917146362706ed460b5ed6624fcc5