Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: runtime/vm/os_android.cc

Issue 1711163002: Remove more things (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/os_android.cc
diff --git a/runtime/vm/os_android.cc b/runtime/vm/os_android.cc
index 9dcd09ece5e6a1af93c4985b4ed285cf743f1d0d..5975735f78d2c175d59177ad100d268dd4cf8c0b 100644
--- a/runtime/vm/os_android.cc
+++ b/runtime/vm/os_android.cc
@@ -21,9 +21,7 @@
#include "platform/utils.h"
#include "vm/code_observers.h"
#include "vm/dart.h"
-#include "vm/debuginfo.h"
#include "vm/isolate.h"
-#include "vm/vtune.h"
#include "vm/zone.h"
@@ -31,12 +29,11 @@ namespace dart {
// Android CodeObservers.
-DEFINE_FLAG(bool, generate_gdb_symbols, false,
- "Generate symbols of generated dart functions for debugging with GDB");
+#ifndef PRODUCT
+
DEFINE_FLAG(bool, generate_perf_events_symbols, false,
"Generate events symbols for profiling with perf");
-
class PerfCodeObserver : public CodeObserver {
public:
PerfCodeObserver() : out_file_(NULL) {
@@ -83,41 +80,7 @@ class PerfCodeObserver : public CodeObserver {
DISALLOW_COPY_AND_ASSIGN(PerfCodeObserver);
};
-
-class GdbCodeObserver : public CodeObserver {
- public:
- GdbCodeObserver() { }
-
- virtual bool IsActive() const {
- return FLAG_generate_gdb_symbols;
- }
-
- virtual void Notify(const char* name,
- uword base,
- uword prologue_offset,
- uword size,
- bool optimized) {
- if (prologue_offset > 0) {
- // In order to ensure that gdb sees the first instruction of a function
- // as the prologue sequence we register two symbols for the cases when
- // the prologue sequence is not the first instruction:
- // <name>_entry is used for code preceding the prologue sequence.
- // <name> for rest of the code (first instruction is prologue sequence).
- char* pname = OS::SCreate(Thread::Current()->zone(),
- "%s_%s", name, "entry");
- DebugInfo::RegisterSection(pname, base, size);
- DebugInfo::RegisterSection(name,
- (base + prologue_offset),
- (size - prologue_offset));
- } else {
- DebugInfo::RegisterSection(name, base, size);
- }
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(GdbCodeObserver);
-};
-
+#endif // !PRODUCT
const char* OS::Name() {
return "android";
@@ -427,15 +390,11 @@ bool OS::StringToInt64(const char* str, int64_t* value) {
void OS::RegisterCodeObservers() {
+#ifndef PRODUCT
if (FLAG_generate_perf_events_symbols) {
CodeObservers::Register(new PerfCodeObserver);
}
- if (FLAG_generate_gdb_symbols) {
- CodeObservers::Register(new GdbCodeObserver);
- }
-#if defined(DART_VTUNE_SUPPORT)
- CodeObservers::Register(new VTuneCodeObserver);
-#endif
+#endif // !PRODUCT
}

Powered by Google App Engine
This is Rietveld 408576698