Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 171113: media_bench optionally dump raw output to a file.... (Closed)

Created:
11 years, 3 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong, Alpha Left Google
Visibility:
Public.

Description

media_bench optionally dump raw output to a file. BUG=20709 TEST=use ffmpeg to dump raw yuv and compare to media_bench output. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25375

Patch Set 1 #

Total comments: 24

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 3

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -5 lines) Patch
M media/bench/bench.cc View 1 2 3 4 5 7 chunks +73 lines, -5 lines 5 comments Download

Messages

Total messages: 5 (0 generated)
scherkus (not reviewing)
http://codereview.chromium.org/171113/diff/1/2 File media/bench/bench.cc (right): http://codereview.chromium.org/171113/diff/1/2#newcode20 Line 20: #include "base/file_util.h" if file_util::ScopedFILE isn't being used, do ...
11 years, 3 months ago (2009-09-02 22:58:23 UTC) #1
fbarchard
yuv dumping tested on windows. pcm should work, but not tested http://codereview.chromium.org/171113/diff/1/2 File media/bench/bench.cc (right): ...
11 years, 3 months ago (2009-09-03 02:06:09 UTC) #2
scherkus (not reviewing)
few more nits but we're looking good! http://codereview.chromium.org/171113/diff/1/2 File media/bench/bench.cc (right): http://codereview.chromium.org/171113/diff/1/2#newcode39 Line 39: bool ...
11 years, 3 months ago (2009-09-03 18:00:55 UTC) #3
Alpha Left Google
LGTM after style issues by scherkus are addressed.
11 years, 3 months ago (2009-09-03 18:08:58 UTC) #4
scherkus (not reviewing)
11 years, 3 months ago (2009-09-03 22:03:35 UTC) #5
woah some stuff slipped through.. create a new CL and TBR if you want

http://codereview.chromium.org/171113/diff/8004/8005
File media/bench/bench.cc (right):

http://codereview.chromium.org/171113/diff/8004/8005#newcode26
Line 26: #include "media/filters/ffmpeg_video_decoder.h"
hmm.. don't think you need to include this

http://codereview.chromium.org/171113/diff/8004/8005#newcode123
Line 123: FILE *output = NULL;
pointer goes with typename

http://codereview.chromium.org/171113/diff/8004/8005#newcode256
Line 256: // TODO(fbarchard): support formats other than YV12.
this comment is out of date

http://codereview.chromium.org/171113/diff/8004/8005#newcode273
Line 273: copy_lines = copy_lines;
redundant?

http://codereview.chromium.org/171113/diff/8004/8005#newcode277
Line 277: copy_lines = copy_lines;
redundant?

Powered by Google App Engine
This is Rietveld 408576698