Fix hung renderer dialog not showing after setting USE_ASH=0

Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which causes the hung renderer dialog never to show because of the check here https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/views/hung_renderer_view.cc&l=256 .

R=sky@chromium.org
BUG=584702
Committed: https://crrev.com/147142b258989ee7fc2c744661b6f5d7e52a3072
Cr-Commit-Position: refs/heads/master@{#376305}

[scottmg, 2016-02-18 20:40:48]

Apparently we have no tests for the hung renderer dialog. I'll see if I can add
an interactive_ui_test one in a follow up.

[scottmg, 2016-02-18 20:41:32]

Description was changed from

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

R=sky@chromium.org
BUG=584702
==========

to

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show.

R=sky@chromium.org
BUG=584702
==========

[scottmg, 2016-02-18 21:44:26]

Description was changed from

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show.

R=sky@chromium.org
BUG=584702
==========

to

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show because of the check here
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
.

R=sky@chromium.org
BUG=584702
==========

[sky, 2016-02-18 22:15:54]

https://codereview.chromium.org/1711113002/diff/20001/chrome/browser/platform...
File chrome/browser/platform_util_aura.cc (right):

https://codereview.chromium.org/1711113002/diff/20001/chrome/browser/platform...
chrome/browser/platform_util_aura.cc:31: #if defined(USE_ASH)
Can you use the non ash:: variants all the time? I believe both end up in the
same place and if we can it would be good to nuke the ifdefs (and the ash
include above).

[scottmg, 2016-02-18 22:20:14]

https://codereview.chromium.org/1711113002/diff/20001/chrome/browser/platform...
File chrome/browser/platform_util_aura.cc (right):

https://codereview.chromium.org/1711113002/diff/20001/chrome/browser/platform...
chrome/browser/platform_util_aura.cc:31: #if defined(USE_ASH)
On 2016/02/18 22:15:54, sky wrote:
> Can you use the non ash:: variants all the time? I believe both end up in the
> same place and if we can it would be good to nuke the ifdefs (and the ash
> include above).

Done. (I didn't remove the ash::wm:: implementations entirely here because
there's a few other uses of them, and this will need to be merged back to 49.)

[sky, 2016-02-18 22:25:31]

LGTM

[scottmg, 2016-02-18 22:31:39]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-02-18 22:35:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1711113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1711113002/40001

[commit-bot: I haz the power, 2016-02-19 00:28:27]

Description was changed from

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show because of the check here
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
.

R=sky@chromium.org
BUG=584702
==========

to

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show because of the check here
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
.

R=sky@chromium.org
BUG=584702
==========

[commit-bot: I haz the power, 2016-02-19 00:28:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-19 00:29:55]

Description was changed from

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show because of the check here
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
.

R=sky@chromium.org
BUG=584702
==========

to

==========
Fix hung renderer dialog not showing after setting USE_ASH=0

When USE_ASH switched to 0, platform_util::IsWindowActive returned false, which
causes the hung renderer dialog never to show because of the check here
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
.

R=sky@chromium.org
BUG=584702

Committed: https://crrev.com/147142b258989ee7fc2c744661b6f5d7e52a3072
Cr-Commit-Position: refs/heads/master@{#376305}
==========

[commit-bot: I haz the power, 2016-02-19 00:29:56]

Patchset 3 (id:??) landed as
https://crrev.com/147142b258989ee7fc2c744661b6f5d7e52a3072
Cr-Commit-Position: refs/heads/master@{#376305}