content/browser/frame_host/render_widget_host_view_guest.cc - Issue 1711103002: Implement lifetime observer on RenderWidgetHostViewBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 1711103002: Implement lifetime observer on RenderWidgetHostViewBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restructure, and make RWHVB derived classes responsible for early notification. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_child_frame.cc ('K') | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/renderer_host/render_widget_host_input_event_router.h » ('j') | content/browser/renderer_host/render_widget_host_input_event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc

index 3a3f7e33bdd1d73971c954348db53d32c57dea7e..f5066562dd92542562367577a52ae5139c660f13 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.cc

+++ b/content/browser/frame_host/render_widget_host_view_guest.cc

@@ -541,7 +541,10 @@ gfx::NativeViewId RenderWidgetHostViewGuest::GetParentForWindowlessPlugin()

#endif

void RenderWidgetHostViewGuest::DestroyGuestView() {

- UnregisterSurfaceNamespaceId();

+ // Let our observers know we're going away, since we don't want any event

+ // processing calls coming in after we release host_.

+ NotifyObserversAboutShutdown();

host_->SetView(NULL);

host_ = NULL;

base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);